linux-kernel - Re: [PATCH v2] lib: stackdepot: Add support to configure STACK_HASH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20201203123253.c00767545ad35c09dabd44ef@linux-foundation.org>
Date:   Thu, 3 Dec 2020 12:32:53 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Vincenzo Frascino <vincenzo.frascino@....com>
Cc:     Andrey Konovalov <andreyknvl@...gle.com>,
        Catalin Marinas <catalin.marinas@....com>,
        vjitta@...eaurora.org, Minchan Kim <minchan@...nel.org>,
        Alexander Potapenko <glider@...gle.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Mark Brown <broonie@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>, ylal@...eaurora.org,
        vinmenon@...eaurora.org, kasan-dev <kasan-dev@...glegroups.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Qian Cai <qcai@...hat.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH v2] lib: stackdepot: Add support to configure
 STACK_HASH_SIZE

On Thu, 3 Dec 2020 17:26:59 +0000 Vincenzo Frascino <vincenzo.frascino@....com> wrote:

> 
> 
> On 12/3/20 4:34 PM, Vincenzo Frascino wrote:
> > Hi Andrey,
> > 
> > On 12/3/20 4:15 PM, Andrey Konovalov wrote:
> >> On Thu, Dec 3, 2020 at 5:04 PM Qian Cai <qcai@...hat.com> wrote:
> >>>
> >>> On Thu, 2020-11-26 at 10:13 +0530, vjitta@...eaurora.org wrote:
> >>>> From: Yogesh Lal <ylal@...eaurora.org>
> >>>>
> >>>> Add a kernel parameter stack_hash_order to configure STACK_HASH_SIZE.
> >>>>
> >>>> Aim is to have configurable value for STACK_HASH_SIZE, so that one
> >>>> can configure it depending on usecase there by reducing the static
> >>>> memory overhead.
> >>>>
> >>>> One example is of Page Owner, default value of STACK_HASH_SIZE lead
> >>>> stack depot to consume 8MB of static memory. Making it configurable
> >>>> and use lower value helps to enable features like CONFIG_PAGE_OWNER
> >>>> without any significant overhead.
> >>>>
> >>>> Suggested-by: Minchan Kim <minchan@...nel.org>
> >>>> Signed-off-by: Yogesh Lal <ylal@...eaurora.org>
> >>>> Signed-off-by: Vijayanand Jitta <vjitta@...eaurora.org>
> >>>
> >>> Reverting this commit on today's linux-next fixed boot crash with KASAN.
> >>>
> >>> .config:
> >>> https://cailca.coding.net/public/linux/mm/git/files/master/x86.config
> >>> https://cailca.coding.net/public/linux/mm/git/files/master/arm64.config
> >>
> >> Vincenzo, Catalin, looks like this is the cause of the crash you
> >> observed. Reverting this commit from next-20201203 fixes KASAN for me.
> >>
> >> Thanks for the report Qian!
> >>
> > 
> > Thank you for this. I will try and let you know as well.
> > 
> 
> Reverting the patch above works for me as well, and the problem seems to be the
> order on which the initcalls are invoked. In fact stackdepot should be
> initialized before kasan from what I can see.

Thanks, all.  I'll drop
lib-stackdepot-add-support-to-configure-stack_hash_size.patch.