linux-kernel - [PATCH] bfs: don't use WARNING: string when it's just info.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20201203212634.17278-1-rdunlap@infradead.org>
Date:   Thu,  3 Dec 2020 13:26:34 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux-kernel@...r.kernel.org
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        syzbot+3fd34060f26e766536ff@...kaller.appspotmail.com,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Al Viro <viro@...IV.linux.org.uk>,
        "Tigran A. Aivazian" <aivazian.tigran@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-fsdevel@...r.kernel.org
Subject: [PATCH] bfs: don't use WARNING: string when it's just info.

Make the printk() [bfs "printf" macro] seem less severe by changing
"WARNING:" to "NOTE:".

<asm-generic/bug.h> warns us about using WARNING or BUG in a
format string other than in WARN() or BUG() family macros.
bfs/inode.c is doing just that in a normal printk() call, so
change the "WARNING" string to be "NOTE".

Reported-by: syzbot+3fd34060f26e766536ff@...kaller.appspotmail.com
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Dmitry Vyukov <dvyukov@...gle.com>
Cc: Al Viro <viro@...IV.linux.org.uk>
Cc: "Tigran A. Aivazian" <aivazian.tigran@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-fsdevel@...r.kernel.org
---
 fs/bfs/inode.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20201127.orig/fs/bfs/inode.c
+++ linux-next-20201127/fs/bfs/inode.c
@@ -350,7 +350,7 @@ static int bfs_fill_super(struct super_b
 
 	info->si_lasti = (le32_to_cpu(bfs_sb->s_start) - BFS_BSIZE) / sizeof(struct bfs_inode) + BFS_ROOT_INO - 1;
 	if (info->si_lasti == BFS_MAX_LASTI)
-		printf("WARNING: filesystem %s was created with 512 inodes, the real maximum is 511, mounting anyway\n", s->s_id);
+		printf("NOTE: filesystem %s was created with 512 inodes, the real maximum is 511, mounting anyway\n", s->s_id);
 	else if (info->si_lasti > BFS_MAX_LASTI) {
 		printf("Impossible last inode number %lu > %d on %s\n", info->si_lasti, BFS_MAX_LASTI, s->s_id);
 		goto out1;