linux-kernel - Re: [PATCH] intel_idle: fix intel_idle_state_needs_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9f5a56dc-d558-b63b-9ebe-5b935a46ba8b@infradead.org>
Date:   Thu, 3 Dec 2020 15:12:23 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Arnd Bergmann <arnd@...nel.org>,
        Jacob Pan <jacob.jun.pan@...ux.intel.com>,
        Len Brown <lenb@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
Cc:     Arnd Bergmann <arnd@...db.de>, Chen Yu <yu.c.chen@...el.com>,
        Borislav Petkov <bp@...e.de>,
        Thomas Gleixner <tglx@...utronix.de>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] intel_idle: fix intel_idle_state_needs_timer_stop build
 failure

On 12/3/20 2:30 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The newly added function is defined inside of an #ifdef section but
> used outside, leading to a build failure:
> 
> drivers/idle/intel_idle.c:1510:7: error: implicit declaration of function 'intel_idle_state_needs_timer_stop' [-Werror,-Wimplicit-function-declaration]
>                 if (intel_idle_state_needs_timer_stop(&drv->states[drv->state_count]))
>                     ^
> 
> Move it ahead of the CONFIG_ACPI_PROCESSOR_CSTATE check.
> 
> Fixes: 6e1d2bc675bd ("intel_idle: Fix intel_idle() vs tracing")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/idle/intel_idle.c | 28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)
> 

Peter has already fixed this one.

thanks.
-- 
~Randy