linux-kernel - Re: [PATCH 1/4] net: ti: am65-cpsw-nuss: Add devlink support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Dec 2020 14:10:48 +0530
From:   Vignesh Raghavendra <vigneshr@...com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Jonathan Corbet <corbet@....net>, Jiri Pirko <jiri@...dia.com>,
        <netdev@...r.kernel.org>, <linux-doc@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Linux ARM Mailing List <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/4] net: ti: am65-cpsw-nuss: Add devlink support

Hi Andrew,

On 11/30/20 9:20 PM, Andrew Lunn wrote:
> On Mon, Nov 30, 2020 at 01:50:43PM +0530, Vignesh Raghavendra wrote:
>> AM65 NUSS ethernet switch on K3 devices can be configured to work either
>> in independent mac mode where each port acts as independent network
>> interface (multi mac) or switch mode.
>>
>> Add devlink hooks to provide a way to switch b/w these modes.
> 
> Hi Vignesh
> 
> What is not clear is why you need this? Ports are independent anyway
> until you add them to a bridge when using switchdev.
> 

Default use case is to support multiple independent ports with no
switching. Users can either use software bridge with multi-mac
configuration or HW bridge for switch functionality. devlink hook
enables users to select Hw supported switch functionality. We don't want
to enable HW based switch support unless explicitly asked by user.
This also matches previous generation of devices (DRA7xx and AM57xx)
supported under drivers/net/ethernet/ti/cpsw_new.c

In general, devlink will also be used to configure few more parameters
(in addition to switch mode) such as host port in ALE_BYPASS mode (to
allow all packets to be routed to host) etc.

Regards
Vignesh