linux-kernel - Re: [PATCH -mmots] checkpatch: add fix for non-standard signature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a2c74693-93ae-cd5a-7836-4ffff643fc09@gmail.com>
Date:   Thu, 3 Dec 2020 15:29:27 +0530
From:   Aditya <yashsri421@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     lukas.bulwahn@...il.com, linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH -mmots] checkpatch: add fix for non-standard signature -
 co-authored-by

On 3/12/20 12:26 am, Joe Perches wrote:
> On Thu, 2020-12-03 at 00:00 +0530, Aditya Srivastava wrote:
>> Currently, checkpatch.pl warns us for BAD_SIGN_OFF on the usage of
>> non-standard signatures.
>>
>> An evaluation on v4.13..v5.8 showed that out of 539 warnings due to
>> non-standard signatures, 43 are due to the use of 'Co-authored-by'
>> tag, which may seem correct, but is not standard.
>>
>> The standard signature equivalent for 'Co-authored-by' is
>> 'Co-developed-by'.
> 
> I'm not going to ack this as I don't mind non-standard signatures.
> 

What do you suggest?
Should I drop this patch and move on?

> You should also always use patch subject versioning and include
> a changelog after the --- line.
> 

Ok, will do. Actually I had not included the version changelogs and
versioning from our previous patch, as the subject for the patch had
changed. Will keep in mind for future though.

Thanks
Aditya

>> Provide a fix by suggesting users with this signature alternative and
>> replacing.
>>
>> Signed-off-by: Aditya Srivastava <yashsri421@...il.com>
>> ---
>>  scripts/checkpatch.pl | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index 4a026926139f..fc036d545d2d 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -2832,6 +2832,9 @@ sub process {
>>  
>>
>>  			if ($sign_off !~ /$signature_tags/) {
>>  				my $suggested_signature = find_standard_signature($sign_off);
>> +				if ($sign_off =~ /co-authored-by:/i) {
>> +					$suggested_signature = "Co-developed-by:";
>> +				}
>>  				if ($suggested_signature eq "") {
>>  					WARN("BAD_SIGN_OFF",
>>  					     "Non-standard signature: $sign_off\n" . $herecurr);
> 
>