linux-kernel - Re: [BUG] intel_idle: build failure on Linux 5.10-rc6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201203100507.GI2414@hirez.programming.kicks-ass.net>
Date:   Thu, 3 Dec 2020 11:05:07 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Rui Salvaterra <rsalvaterra@...il.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [BUG] intel_idle: build failure on Linux 5.10-rc6

On Thu, Dec 03, 2020 at 09:23:11AM +0000, Rui Salvaterra wrote:
> Hi, Peter,
> 
> I'm sorry to bother you, but commit
> 6e1d2bc675bd57640f5658a4a657ae488db4c204 ("intel_idle: Fix
> intel_idle() vs tracing") broke my build, when CONFIG_ACPI_PROCESSOR
> is disabled (possibly because it selects CONFIG_ACPI_PROCESSOR_IDLE):
> 
> drivers/idle/intel_idle.c: In function ‘intel_idle_init_cstates_icpu’:
> drivers/idle/intel_idle.c:1510:7: error: implicit declaration of
> function ‘intel_idle_state_needs_timer_stop’
> [-Werror=implicit-function-declaration]
>  1510 |   if (intel_idle_state_needs_timer_stop(&drv->states[drv->state_count]))
>       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Reverting the aforementioned commit fixes it. Config attached. Please
> let me know if you need anything else!

Yeah sorry about that, just queued the build fix.

https://git.kernel.org/tip/4d916140bf28ff027997144ea1bb4299e1536f87