lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 Dec 2020 17:17:51 -0800 From: Doug Anderson <dianders@...omium.org> To: Stephen Boyd <swboyd@...omium.org> Cc: Benson Leung <bleung@...omium.org>, Enric Balletbo i Serra <enric.balletbo@...labora.com>, LKML <linux-kernel@...r.kernel.org>, Simon Glass <sjg@...omium.org>, Gwendal Grignou <gwendal@...omium.org>, Alexandru M Stan <amstan@...omium.org> Subject: Re: [PATCH 1/2] platform/chrome: cros_ec_spi: Don't overwrite spi::mode Hi, On Wed, Dec 2, 2020 at 5:16 PM Stephen Boyd <swboyd@...omium.org> wrote: > > There isn't any need to overwrite the mode here in the driver with what > has been detected by the firmware, such as DT or ACPI. In fact, if we > use the SPI CS gpio descriptor feature we will overwrite the mode with > SPI_MODE_0 where it already contains SPI_MODE_0 and more importantly > SPI_CS_HIGH. Clearing the SPI_CS_HIGH bit causes the CS line to toggle > when the device is probed when it shouldn't change, confusing the driver > and making it fail to probe. Drop the assignment and let the spi core > take care of it. > > Fixes: a17d94f0b6e1 ("mfd: Add ChromeOS EC SPI driver") > Cc: Simon Glass <sjg@...omium.org> > Cc: Gwendal Grignou <gwendal@...omium.org> > Cc: Douglas Anderson <dianders@...omium.org> > Cc: Alexandru M Stan <amstan@...omium.org> > Signed-off-by: Stephen Boyd <swboyd@...omium.org> > --- > drivers/platform/chrome/cros_ec_spi.c | 1 - Reviewed-by: Douglas Anderson <dianders@...omium.org> Tested-by: Douglas Anderson <dianders@...omium.org>
Powered by blists - more mailing lists