linux-kernel - [PATCH 04/11] drivers: staging: goldfish: remove unneeded MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu,  3 Dec 2020 13:47:56 +0100
From:   "Enrico Weigelt, metux IT consult" <info@...ux.net>
To:     linux-kernel@...r.kernel.org
Cc:     rspringer@...gle.com, toddpoynor@...gle.com, benchan@...omium.org,
        rcy@...gle.com, laurent.pinchart@...asonboard.com,
        mchehab@...nel.org, f.fainelli@...il.com, rjui@...adcom.com,
        sbranden@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
        nsaenzjulienne@...e.de, speakup@...ux-speakup.org,
        devel@...verdev.osuosl.org, linux-media@...r.kernel.org,
        netdev@...r.kernel.org
Subject: [PATCH 04/11] drivers: staging: goldfish: remove unneeded MODULE_VERSION() call

Remove MODULE_VERSION(), as it doesn't seem to have much practical purpose.
For in-kernel drivers, the kernel version matters. The driver received lots
of changes, but version number has remained the same since it's introducing
into mainline, seven years ago. So, it doesn't seem to have much practical
meaning anymore.

Signed-off-by: Enrico Weigelt <info@...ux.net>
---
 drivers/staging/goldfish/goldfish_audio.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c
index 0c65a0121dde..4a23f40e549a 100644
--- a/drivers/staging/goldfish/goldfish_audio.c
+++ b/drivers/staging/goldfish/goldfish_audio.c
@@ -24,7 +24,6 @@
 MODULE_AUTHOR("Google, Inc.");
 MODULE_DESCRIPTION("Android QEMU Audio Driver");
 MODULE_LICENSE("GPL");
-MODULE_VERSION("1.0");
 
 struct goldfish_audio {
 	char __iomem *reg_base;
-- 
2.11.0