linux-kernel - Re: [PATCH v10 2/3] ARM: uncompress: Add OF_DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXGy=ZLRg_+d-amY2FNj7hrZOM2umHcCiFYY5_eZsG95AQ@mail.gmail.com>
Date:   Thu, 3 Dec 2020 13:50:08 +0100
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Russell King <linux@...linux.org.uk>,
        Nicolas Pitre <nico@...xnic.net>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Dmitry Osipenko <digetx@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        Eric Miao <eric.miao@...dia.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Lukasz Stelmach <l.stelmach@...sung.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Chris Brandt <chris.brandt@...esas.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v10 2/3] ARM: uncompress: Add OF_DT_MAGIC macro

On Thu, 3 Dec 2020 at 13:19, Geert Uytterhoeven <geert+renesas@...der.be> wrote:
>
> The DTB magic marker is stored as a 32-bit big-endian value, and thus
> depends on the CPU's endianness.  Add a macro to define this value in
> native endianness, to reduce #ifdef clutter and (future) duplication.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Reviewed-by: Ard Biesheuvel <ardb@...nel.org>

> ---
> v10:
>   - New.
> ---
>  arch/arm/boot/compressed/head.S | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S
> index aabdc544c03aafdc..d9cce7238a365081 100644
> --- a/arch/arm/boot/compressed/head.S
> +++ b/arch/arm/boot/compressed/head.S
> @@ -11,6 +11,12 @@
>
>  #include "efi-header.S"
>
> +#ifdef __ARMEB__
> +#define OF_DT_MAGIC 0xd00dfeed
> +#else
> +#define OF_DT_MAGIC 0xedfe0dd0
> +#endif
> +
>   AR_CLASS(     .arch   armv7-a )
>   M_CLASS(      .arch   armv7-m )
>
> @@ -335,11 +341,7 @@ restart:   adr     r0, LC1
>   */
>
>                 ldr     lr, [r6, #0]
> -#ifndef __ARMEB__
> -               ldr     r1, =0xedfe0dd0         @ sig is 0xd00dfeed big endian
> -#else
> -               ldr     r1, =0xd00dfeed
> -#endif
> +               ldr     r1, =OF_DT_MAGIC
>                 cmp     lr, r1
>                 bne     dtb_check_done          @ not found
>
> --
> 2.25.1
>