lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 3 Dec 2020 01:09:11 +0100 From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com> To: Axel Rasmussen <axelrasmussen@...gle.com> Cc: Peter Xu <peterx@...hat.com>, Shuah Khan <shuah@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>, Joe Perches <joe@...ches.com>, Mike Rapoport <rppt@...ux.vnet.ibm.com>, Andrea Arcangeli <aarcange@...hat.com>, David Alan Gilbert <dgilbert@...hat.com>, Greg Thelen <gthelen@...gle.com>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] userfaultfd: selftests: make __{s,u}64 format specifiers portable On Thu, Dec 3, 2020 at 12:55 AM Axel Rasmussen <axelrasmussen@...gle.com> wrote: > > This is what clang-format yields. Are you thinking it would be better > to line everything up with the ( in uffd_error( ? Yeah, sometimes clang-format cannot do a good job with the 80 column limit + 8 tabs. You are definitely not forced to follow clang-format output by any means. Subsystem maintainers decide what style they prefer anyway, which could range from a manual approach to following clang-format strictly. Clang-format implements the general kernel style as closely as we could get it so far (it will improve more in the future when we raise the minimum clang-format version required). See Doc/process/clang-format.rst. > Or, perhaps this case is a good reason to make uffd_error() a variadic > macro so we can insert "-EEXIST" || "error" with a "%s". ...and indeed, sometimes it is a hint that simplifying things could help :-) Cheers, Miguel
Powered by blists - more mailing lists