lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 3 Dec 2020 01:09:11 +0100
From:   Miguel Ojeda <>
To:     Axel Rasmussen <>
Cc:     Peter Xu <>, Shuah Khan <>,
        Andrew Morton <>,
        Joe Perches <>,
        Mike Rapoport <>,
        Andrea Arcangeli <>,
        David Alan Gilbert <>,
        Greg Thelen <>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        LKML <>
Subject: Re: [PATCH] userfaultfd: selftests: make __{s,u}64 format specifiers portable

On Thu, Dec 3, 2020 at 12:55 AM Axel Rasmussen <> wrote:
> This is what clang-format yields. Are you thinking it would be better
> to line everything up with the ( in uffd_error( ?

Yeah, sometimes clang-format cannot do a good job with the 80 column
limit + 8 tabs.

You are definitely not forced to follow clang-format output by any
means. Subsystem maintainers decide what style they prefer anyway,
which could range from a manual approach to following clang-format
strictly. Clang-format implements the general kernel style as closely
as we could get it so far (it will improve more in the future when we
raise the minimum clang-format version required). See

> Or, perhaps this case is a good reason to make uffd_error() a variadic
> macro so we can insert "-EEXIST" || "error" with a "%s".

...and indeed, sometimes it is a hint that simplifying things could help :-)


Powered by blists - more mailing lists