linux-kernel - Re: [PATCH v4 2/3] spi: Add SPI_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vd-23R0EeXLMFBqsxy4HzC2huGYPJm6LX6r1==bh5xg2A@mail.gmail.com>
Date:   Thu, 3 Dec 2020 16:27:26 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>
Cc:     linux-spi <linux-spi@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        "Bogdan, Dragos" <dragos.bogdan@...log.com>
Subject: Re: [PATCH v4 2/3] spi: Add SPI_NO_TX/RX support

On Thu, Dec 3, 2020 at 4:10 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Thu, Dec 3, 2020 at 4:00 PM Alexandru Ardelean
> <alexandru.ardelean@...log.com> wrote:

> > +#define SPI_NO_TX      BIT(31)         /* no transmit wire */
> > +#define SPI_NO_RX      BIT(30)         /* no receive wire */
> > +#define SPI_MODE_KERNEL_MASK   (SPI_NO_TX | SPI_NO_RX)
>
> This needs a comment to explain what's going on with the flags (split).

...and to be consistent with proposal in uAPI:

#define SPI_MODE_KERNEL_MASK   (~(BIT(30) - 1))

-- 
With Best Regards,
Andy Shevchenko