linux-kernel - RE: [PATCH -next] regulator: da9121: Mark some symbols with static keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR10MB2807AEED4498B051B227E7D8ECF20@AM6PR10MB2807.EURPRD10.PROD.OUTLOOK.COM>
Date:   Thu, 3 Dec 2020 14:37:48 +0000
From:   Adam Ward <Adam.Ward.opensource@...semi.com>
To:     Zou Wei <zou_wei@...wei.com>,
        Support Opensource <Support.Opensource@...semi.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH -next] regulator: da9121: Mark some symbols with static
 keyword

Acked-by: Adam Ward <Adam.Ward.opensource@...semi.com>

> -----Original Message-----
> From: Zou Wei <zou_wei@...wei.com>
> Sent: 03 December 2020 11:27
> To: Support Opensource <Support.Opensource@...semi.com>;
> lgirdwood@...il.com; broonie@...nel.org
> Cc: linux-kernel@...r.kernel.org; Zou Wei <zou_wei@...wei.com>
> Subject: [PATCH -next] regulator: da9121: Mark some symbols with static
> keyword
> 
> Fix the following sparse warnings:
> 
> drivers/regulator/da9121-regulator.c:55:21: warning: symbol
> 'da9121_10A_2phase_current' was not declared. Should it be static?
> drivers/regulator/da9121-regulator.c:63:21: warning: symbol
> 'da9121_6A_2phase_current' was not declared. Should it be static?
> drivers/regulator/da9121-regulator.c:71:21: warning: symbol
> 'da9121_5A_1phase_current' was not declared. Should it be static?
> drivers/regulator/da9121-regulator.c:79:21: warning: symbol
> 'da9121_3A_1phase_current' was not declared. Should it be static?
> drivers/regulator/da9121-regulator.c:151:32: warning: symbol
> 'status_event_handling' was not declared. Should it be static?
> 
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>  drivers/regulator/da9121-regulator.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/regulator/da9121-regulator.c b/drivers/regulator/da9121-
> regulator.c
> index 3ead6a1..893512c 100644
> --- a/drivers/regulator/da9121-regulator.c
> +++ b/drivers/regulator/da9121-regulator.c
> @@ -52,7 +52,7 @@ struct da9121_range {
>  	int reg_max;
>  };
> 
> -struct da9121_range da9121_10A_2phase_current = {
> +static struct da9121_range da9121_10A_2phase_current = {
>  	.val_min =  7000000,
>  	.val_max = 20000000,
>  	.val_stp =  1000000,
> @@ -60,7 +60,7 @@ struct da9121_range da9121_10A_2phase_current = {
>  	.reg_max = 14,
>  };
> 
> -struct da9121_range da9121_6A_2phase_current = {
> +static struct da9121_range da9121_6A_2phase_current = {
>  	.val_min =  7000000,
>  	.val_max = 12000000,
>  	.val_stp =  1000000,
> @@ -68,7 +68,7 @@ struct da9121_range da9121_6A_2phase_current = {
>  	.reg_max = 6,
>  };
> 
> -struct da9121_range da9121_5A_1phase_current = {
> +static struct da9121_range da9121_5A_1phase_current = {
>  	.val_min =  3500000,
>  	.val_max = 10000000,
>  	.val_stp =   500000,
> @@ -76,7 +76,7 @@ struct da9121_range da9121_5A_1phase_current = {
>  	.reg_max = 14,
>  };
> 
> -struct da9121_range da9121_3A_1phase_current = {
> +static struct da9121_range da9121_3A_1phase_current = {
>  	.val_min = 3500000,
>  	.val_max = 6000000,
>  	.val_stp =  500000,
> @@ -148,7 +148,7 @@ struct status_event_data {
>   *
>   * GPIO0/1/2 are not configured for use by default, so should not be seen.
>   */
> -const struct status_event_data status_event_handling[] = {
> +static const struct status_event_data status_event_handling[] = {
>  	DA9xxx_STATUS(0, 0, SG, 0, "Handled E_SG\n"),
>  	DA9121_STATUS(0, 0, TEMP_CRIT,
> (REGULATOR_EVENT_OVER_TEMP|REGULATOR_EVENT_DISABLE), NULL),
>  	DA9121_STATUS(0, 0, TEMP_WARN,
> REGULATOR_EVENT_OVER_TEMP, NULL),
> --
> 2.6.2