linux-kernel - Re: [PATCH] ARM: keystone: remove SECTION_SIZE_BITS/MAX_PHYSMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 3 Dec 2020 17:57:52 -0800
From:   santosh.shilimkar@...cle.com
To:     Arnd Bergmann <arnd@...nel.org>, soc@...nel.org,
        Santosh Shilimkar <ssantosh@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: keystone: remove SECTION_SIZE_BITS/MAX_PHYSMEM_BITS

On 12/3/20 3:18 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> These definitions are evidently left over from the days when
> sparsemem settings were platform specific. This was no longer
> the case when the platform got merged.
> 
> There was no warning in the past, but now the asm/sparsemem.h
> header ends up being included indirectly, causing this warning:
> 
> In file included from /git/arm-soc/arch/arm/mach-keystone/keystone.c:24:
> arch/arm/mach-keystone/memory.h:10:9: warning: 'SECTION_SIZE_BITS' macro redefined [-Wmacro-redefined]
>   #define SECTION_SIZE_BITS       34
>          ^
> arch/arm/include/asm/sparsemem.h:23:9: note: previous definition is here
>   #define SECTION_SIZE_BITS       28
>          ^
> 
> Clearly the definitions never had any effect here, so remove them.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
Acked-by: Santosh Shilimkar <ssantosh@...nel.org>