linux-kernel - Re: [PATCH v14 04/10] fs/ntfs3: Add file operations and implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X8qC3NaNv1kmCO4c@sol.localdomain>
Date:   Fri, 4 Dec 2020 10:41:32 -0800
From:   Eric Biggers <ebiggers@...nel.org>
To:     Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
Cc:     linux-fsdevel@...r.kernel.org, viro@...iv.linux.org.uk,
        linux-kernel@...r.kernel.org, pali@...nel.org, dsterba@...e.cz,
        aaptel@...e.com, willy@...radead.org, rdunlap@...radead.org,
        joe@...ches.com, mark@...mstone.com, nborisov@...e.com,
        linux-ntfs-dev@...ts.sourceforge.net, anton@...era.com,
        dan.carpenter@...cle.com, hch@....de
Subject: Re: [PATCH v14 04/10] fs/ntfs3: Add file operations and
 implementation

On Fri, Dec 04, 2020 at 06:45:54PM +0300, Konstantin Komarov wrote:
> +/* external compression lzx/xpress */
> +static int decompress_lzx_xpress(struct ntfs_sb_info *sbi, const char *cmpr,
> +				 size_t cmpr_size, void *unc, size_t unc_size,
> +				 u32 frame_size)
> +{
> +	int err;
> +	void *ctx;
> +
> +	if (cmpr_size == unc_size) {
> +		/* frame not compressed */
> +		memcpy(unc, cmpr, unc_size);
> +		return 0;
> +	}
> +
> +	err = 0;
> +	ctx = NULL;
> +	spin_lock(&sbi->compress.lock);
> +	if (frame_size == 0x8000) {
> +		/* LZX: frame compressed */
> +		if (!sbi->compress.lzx) {
> +			/* Lazy initialize lzx decompress context */
> +			spin_unlock(&sbi->compress.lock);
> +			ctx = lzx_allocate_decompressor(0x8000);
> +			if (!ctx)
> +				return -ENOMEM;
> +			if (IS_ERR(ctx)) {
> +				/* should never failed */
> +				err = PTR_ERR(ctx);
> +				goto out;
> +			}
> +
> +			spin_lock(&sbi->compress.lock);
> +			if (!sbi->compress.lzx) {
> +				sbi->compress.lzx = ctx;
> +				ctx = NULL;
> +			}
> +		}
> +
> +		if (lzx_decompress(sbi->compress.lzx, cmpr, cmpr_size, unc,
> +				   unc_size)) {
> +			err = -EINVAL;
> +		}
> +	} else {
> +		/* XPRESS: frame compressed */
> +		if (!sbi->compress.xpress) {
> +			/* Lazy initialize xpress decompress context */
> +			spin_unlock(&sbi->compress.lock);
> +			ctx = xpress_allocate_decompressor();
> +			if (!ctx)
> +				return -ENOMEM;
> +
> +			spin_lock(&sbi->compress.lock);
> +			if (!sbi->compress.xpress) {
> +				sbi->compress.xpress = ctx;
> +				ctx = NULL;
> +			}
> +		}
> +
> +		if (xpress_decompress(sbi->compress.xpress, cmpr, cmpr_size,
> +				      unc, unc_size)) {
> +			err = -EINVAL;
> +		}
> +	}
> +	spin_unlock(&sbi->compress.lock);
> +out:
> +	ntfs_free(ctx);
> +	return err;
> +}

Decompression is a somewhat heavyweight operation.  Not the type of thing that
should be done while holding a spin lock.

- Eric