linux-kernel - Re: [PATCH 02/25] bpf: Add size arg to build_id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201204233027.GL3613628@krava>
Date:   Sat, 5 Dec 2020 00:30:27 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Song Liu <songliubraving@...com>
Cc:     Jiri Olsa <jolsa@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Ingo Molnar <mingo@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Michael Petlan <mpetlan@...hat.com>,
        Ian Rogers <irogers@...gle.com>,
        Stephane Eranian <eranian@...gle.com>,
        Alexey Budankov <alexey.budankov@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH 02/25] bpf: Add size arg to build_id_parse function

On Thu, Dec 03, 2020 at 09:23:52PM +0000, Song Liu wrote:
> 
> 
> > On Nov 26, 2020, at 9:00 AM, Jiri Olsa <jolsa@...nel.org> wrote:
> > 
> > It's possible to have other build id types (other than default SHA1).
> > Currently there's also ld support for MD5 build id.
> > 
> > Adding size argument to build_id_parse function, that returns (if defined)
> > size of the parsed build id, so we can recognize the build id type.
> > 
> > Cc: Alexei Starovoitov <ast@...nel.org>
> > Cc: Song Liu <songliubraving@...com>
> > Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> 
> Sorry for the late response. The patch looks good to me. 
> 
> Acked-by: Song Liu <songliubraving@...com>
> 
> with one nitpick below. 
> 
> > ---
> > include/linux/buildid.h |  3 ++-
> > kernel/bpf/stackmap.c   |  2 +-
> > lib/buildid.c           | 29 +++++++++++++++++++++--------
> > 3 files changed, 24 insertions(+), 10 deletions(-)
> > 
> > diff --git a/include/linux/buildid.h b/include/linux/buildid.h
> > index 3be5b49719f1..72639d433873 100644
> > --- a/include/linux/buildid.h
> > +++ b/include/linux/buildid.h
> > @@ -6,6 +6,7 @@
> > 
> > #define BUILD_ID_SIZE 20
> 
> Since we are handling build-id with different sizes, how about we 
> rename this as BUILD_ID_SIZE_MAX or BUILD_ID_SIZE_DEFAULT? 

right, BUILD_ID_SIZE_MAX sounds good to me

thanks,
jirka