linux-kernel - Re: [PATCH net] net: bridge: vlan: fix error return code in __vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201204154254.4c982c31@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Fri, 4 Dec 2020 15:42:54 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Nikolay Aleksandrov <nikolay@...dia.com>,
        Zhang Changzhong <zhangchangzhong@...wei.com>
Cc:     Roopa Prabhu <roopa@...dia.com>,
        "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: bridge: vlan: fix error return code in
 __vlan_add()

On Fri, 4 Dec 2020 12:47:07 +0200 Nikolay Aleksandrov wrote:
> On 04/12/2020 10:48, Zhang Changzhong wrote:
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> > 
> > Fixes: f8ed289fab84 ("bridge: vlan: use br_vlan_(get|put)_master to deal with refcounts")
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>
> 
> Acked-by: Nikolay Aleksandrov <nikolay@...dia.com>

Applied, thanks!