linux-kernel - Re: [PATCH net] openvswitch: fix error return code in validate_and_copy_dec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201204154451.011d9034@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Fri, 4 Dec 2020 15:44:51 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Eelco Chaudron" <echaudro@...hat.com>,
        "Wang Hai" <wanghai38@...wei.com>
Cc:     pshelar@....org, davem@...emloft.net, dev@...nvswitch.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] openvswitch: fix error return code in
 validate_and_copy_dec_ttl()

On Fri, 04 Dec 2020 13:07:48 +0100 Eelco Chaudron wrote:
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Changing 'return start' to 'return action_start' can fix this bug.
> >
> > Fixes: 69929d4c49e1 ("net: openvswitch: fix TTL decrement action 
> > netlink message format")
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Signed-off-by: Wang Hai <wanghai38@...wei.com>  
> 
> Thanks for fixing!
> 
> Reviewed-by: Eelco Chaudron <echaudro@...hat.com>

Applied, thanks!