lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 3 Dec 2020 16:20:22 -0800 From: Josh Don <joshdon@...gle.com> To: Peter Zijlstra <peterz@...radead.org> Cc: Joel Fernandes <joel@...lfernandes.org>, Nishanth Aravamudan <naravamudan@...italocean.com>, Julien Desfossez <jdesfossez@...italocean.com>, Tim Chen <tim.c.chen@...ux.intel.com>, Vineeth Pillai <viremana@...ux.microsoft.com>, Aaron Lu <aaron.lwe@...il.com>, Aubrey Li <aubrey.intel@...il.com>, Thomas Gleixner <tglx@...utronix.de>, linux-kernel <linux-kernel@...r.kernel.org>, mingo@...nel.org, torvalds@...ux-foundation.org, fweisbec@...il.com, Kees Cook <keescook@...omium.org>, Greg Kerr <kerrnel@...gle.com>, Phil Auld <pauld@...hat.com>, Valentin Schneider <valentin.schneider@....com>, Mel Gorman <mgorman@...hsingularity.net>, Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>, Paolo Bonzini <pbonzini@...hat.com>, vineeth@...byteword.org, Chen Yu <yu.c.chen@...el.com>, Christian Brauner <christian.brauner@...ntu.com>, Agata Gruza <agata.gruza@...el.com>, Antonio Gomez Iglesias <antonio.gomez.iglesias@...el.com>, graf@...zon.com, konrad.wilk@...cle.com, dfaggioli@...e.com, Paul Turner <pjt@...gle.com>, Steven Rostedt <rostedt@...dmis.org>, Patrick Bellasi <derkling@...gle.com>, benbjiang@...cent.com, Alexandre Chartre <alexandre.chartre@...cle.com>, James.Bottomley@...senpartnership.com, OWeisse@...ch.edu, Dhaval Giani <dhaval.giani@...cle.com>, Junaid Shahid <junaids@...gle.com>, Jesse Barnes <jsbarnes@...gle.com>, chris.hyser@...cle.com, Ben Segall <bsegall@...gle.com>, Hao Luo <haoluo@...gle.com>, Tom Lendacky <thomas.lendacky@....com>, Aubrey Li <aubrey.li@...ux.intel.com>, "Paul E. McKenney" <paulmck@...nel.org>, Tim Chen <tim.c.chen@...el.com>, Oleg Rombakh <olegrom@...gle.com> Subject: Re: [PATCH -tip 22/32] sched: Split the cookie and setup per-task cookie on fork On Tue, Dec 1, 2020 at 11:55 PM Peter Zijlstra <peterz@...radead.org> wrote: > > Then disallow sharing a task cookie when the tasks are in different > cgroups or disallow cgroup movement when they share a cookie. Yes, we could restrict task cookie sharing to tasks that are in the same cgroup. Then the cookie easily just becomes a single value; either the task cookie or group cookie. The advantage of the approach with the cookie struct is that it is easily extensible, and allows for trust models that don't conform exactly to the cgroup hierarchy (ie. our discussion on cookie color). The overhead of the approach seems tolerable, given that updates to a task's cookie are not in fast paths (ie. prctl, setting cgroup cookie, sched_move_task). Are you more concerned with the added complexity of maintaining the RB tree, refcounts, etc?
Powered by blists - more mailing lists