linux-kernel - Re: [PATCH] x86/sgx: Return -EINVAL on a zero length buffer in sgx_ioc_enclave_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201204051934.GR2789@kadam>
Date:   Fri, 4 Dec 2020 08:19:34 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Jarkko Sakkinen <jarkko@...nel.org>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org,
        linux-sgx@...r.kernel.org,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH] x86/sgx: Return -EINVAL on a zero length buffer in
 sgx_ioc_enclave_add_pages()

On Thu, Dec 03, 2020 at 08:35:27PM +0200, Jarkko Sakkinen wrote:
> The length documented as
> 
>  * @length:     length of the data (multiple of the page size)
> 
> Fail with -EINVAL, when user gives a zero length buffer. Right now
> 'ret' is returned as uninitialized.
> 
> Cc: Dave Hansen <dave.hansen@...ux.intel.com>
> Cc: Borislav Petkov <bp@...en8.de>
> Link: https://lore.kernel.org/linux-sgx/X8ehQssnslm194ld@mwanda/ 
> Fixes: c6d26d370767 ("x86/sgx: Add SGX_IOC_ENCLAVE_ADD_PAGES")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Jarkko Sakkinen <jarkko@...nel.org>

Acked-by: Dan Carpenter <dan.carpenter@...cle.com>

regards,
dan carpenter