linux-kernel - Re: [PATCH][next] wilc1000: remove redundant assignment to pointer vif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Dec 2020 06:39:53 +0000
From:   <Ajay.Kathat@...rochip.com>
To:     <colin.king@...onical.com>, <Claudiu.Beznea@...rochip.com>,
        <kvalo@...eaurora.org>, <davem@...emloft.net>, <kuba@...nel.org>,
        <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] wilc1000: remove redundant assignment to pointer
 vif



On 03/12/20 11:13 pm, Colin King wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> The assignment to pointer vif is redundant as the assigned value
> is never read, hence it can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Thanks.

Acked-by: Ajay Singh <ajay.kathat@...rochip.com>

> ---
>  drivers/net/wireless/microchip/wilc1000/wlan.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.c b/drivers/net/wireless/microchip/wilc1000/wlan.c
> index 993ea7c03429..c12f27be9f79 100644
> --- a/drivers/net/wireless/microchip/wilc1000/wlan.c
> +++ b/drivers/net/wireless/microchip/wilc1000/wlan.c
> @@ -685,7 +685,6 @@ int wilc_wlan_handle_txq(struct wilc *wilc, u32 *txq_count)
>                         if (!tqe_q[ac])
>                                 continue;
> 
> -                       vif = tqe_q[ac]->vif;
>                         ac_exist = 1;
>                         for (k = 0; (k < num_pkts_to_add[ac]) &&
>                              (!max_size_over) && tqe_q[ac]; k++) {
> --
> 2.29.2
>