linux-kernel - Re: [PATCH v3] x86/pci: fix the function type for check_reserved

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+icZUUowgV6dj0=EeDzD9i7a2o_8wyK_Cinb6J7Gmb5JM2eKg@mail.gmail.com>
Date:   Fri, 4 Dec 2020 09:47:08 +0100
From:   Sedat Dilek <sedat.dilek@...il.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     Sami Tolvanen <samitolvanen@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Randy Dunlap <rdunlap@...radead.org>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] x86/pci: fix the function type for check_reserved_t

On Wed, Dec 2, 2020 at 8:39 PM Kees Cook <keescook@...omium.org> wrote:
>
> On Mon, Nov 30, 2020 at 11:39:00AM -0800, Sami Tolvanen wrote:
> > e820__mapped_all is passed as a callback to is_mmconf_reserved,
> > which expects a function of type:
> >
> > typedef bool (*check_reserved_t)(u64 start, u64 end, unsigned type);
> >
> > However, e820__mapped_all accepts enum e820_type as the last
> > argument and this type mismatch trips indirect call checking with
> > Clang's Control-Flow Integrity (CFI).
> >
> > As is_mmconf_reserved only passes enum e820_type values for the
> > type argument, change the typedef and the unused type argument in
> > is_acpi_reserved to enum e820_type to fix the type mismatch.
> >
> > Reported-by: Sedat Dilek <sedat.dilek@...il.com>
> > Suggested-by: Borislav Petkov <bp@...en8.de>
> > Signed-off-by: Sami Tolvanen <samitolvanen@...gle.com>
>
> Reviewed-by: Kees Cook <keescook@...omium.org>
>

Hi Sami,

Back from a time-out...

Please add my:

Tested-by: Sedat Dilek <sedat.dilek@...il.com>

I have some other patches which I had reported when testing Clang-CFI
against Linux v5.9 which misses my Tested-by.
I know we did all that reporting and testing via private email, so it
is as it is.
Reported-by is half-done...

Thanks.

Regards,
- Sedat -