linux-kernel - Re: [PATCH] ASoC: atmel: mchp-spdifrx needs COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Dec 2020 09:11:40 +0000
From:   <Codrin.Ciubotariu@...rochip.com>
To:     <arnd@...nel.org>, <lgirdwood@...il.com>, <broonie@...nel.org>,
        <perex@...ex.cz>, <tiwai@...e.com>, <Nicolas.Ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>, <Ludovic.Desroches@...rochip.com>
CC:     <arnd@...db.de>, <alsa-devel@...a-project.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: atmel: mchp-spdifrx needs COMMON_CLK

On 04.12.2020 00:38, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Compile-testing this driver on an older platform without CONFIG_COMMON_CLK fails with
> 
> ERROR: modpost: "clk_set_min_rate" [sound/soc/atmel/snd-soc-mchp-spdifrx.ko] undefined!
> 
> Make this is a strict dependency.
> 
> Fixes: ef265c55c1ac ("ASoC: mchp-spdifrx: add driver for SPDIF RX")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>

Thanks!

> ---
>   sound/soc/atmel/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
> index bd8854bfd2ee..142373ec411a 100644
> --- a/sound/soc/atmel/Kconfig
> +++ b/sound/soc/atmel/Kconfig
> @@ -148,6 +148,7 @@ config SND_MCHP_SOC_SPDIFTX
>   config SND_MCHP_SOC_SPDIFRX
>          tristate "Microchip ASoC driver for boards using S/PDIF RX"
>          depends on OF && (ARCH_AT91 || COMPILE_TEST)
> +       depends on COMMON_CLK
>          select SND_SOC_GENERIC_DMAENGINE_PCM
>          select REGMAP_MMIO
>          help
> --
> 2.27.0
>