lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 4 Dec 2020 10:15:48 +0100
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Stephen Boyd <swboyd@...omium.org>,
        Benson Leung <bleung@...omium.org>
Cc:     linux-kernel@...r.kernel.org, Simon Glass <sjg@...omium.org>,
        Gwendal Grignou <gwendal@...omium.org>,
        Douglas Anderson <dianders@...omium.org>,
        Alexandru M Stan <amstan@...omium.org>
Subject: Re: [PATCH 2/2] platform/chrome: cros_ec_spi: Drop bits_per_word
 assignment

Hi Stephen,

Thank you for your patch.

On 3/12/20 2:16, Stephen Boyd wrote:
> This is already handed by default in spi_setup() if the bits_per_word is
> 0, so just drop it to shave off a line.
> 
> Cc: Simon Glass <sjg@...omium.org>
> Cc: Gwendal Grignou <gwendal@...omium.org>
> Cc: Douglas Anderson <dianders@...omium.org>
> Cc: Alexandru M Stan <amstan@...omium.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>

Acked-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>

> ---
>  drivers/platform/chrome/cros_ec_spi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/platform/chrome/cros_ec_spi.c b/drivers/platform/chrome/cros_ec_spi.c
> index f9df218fc2bb..14c4046fa04d 100644
> --- a/drivers/platform/chrome/cros_ec_spi.c
> +++ b/drivers/platform/chrome/cros_ec_spi.c
> @@ -741,7 +741,6 @@ static int cros_ec_spi_probe(struct spi_device *spi)
>  	struct cros_ec_spi *ec_spi;
>  	int err;
>  
> -	spi->bits_per_word = 8;
>  	spi->rt = true;
>  	err = spi_setup(spi);
>  	if (err < 0)
> 

Powered by blists - more mailing lists