lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 4 Dec 2020 09:22:34 +0800
From:   Yunfeng Ye <>
To:     Mel Gorman <>
CC:     <>, <>,
        <>, <>,
        <>, <>,
        <>, <>,
        <>, Shiyuan Hu <>,
        Hewenliang <>
Subject: Re: [PATCH 2/2] sched: Split the function show_schedstat()

On 2020/12/3 17:42, Mel Gorman wrote:
> On Thu, Dec 03, 2020 at 02:47:14PM +0800, Yunfeng Ye wrote:
>> The schedstat include runqueue-specific stats and domain-specific stats,
>> so split it into two functions, show_rqstat() and show_domainstat().
>> No functional changes.
>> Signed-off-by: Yunfeng Ye <>
> Why?
> I could understand if there was a follow-up patch that adjusted some
> subset or there was a difference in checking for schedstat_enabled,
> locking or inserting new schedstat information. This can happen in the
> general case when the end result is easier to review here it seems to be
> just moving code around.
The rqstat and domainstat is independent state information. so I think
split it into two individual function is clearer.


Powered by blists - more mailing lists