linux-kernel - Re: [PATCH] arm64: cpufeature: fix unused function warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201204095909.GC461@willie-the-truck>
Date:   Fri, 4 Dec 2020 09:59:10 +0000
From:   Will Deacon <will@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Catalin Marinas <catalin.marinas@....com>,
        Mark Rutland <mark.rutland@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Anshuman Khandual <anshuman.khandual@....com>,
        Ionela Voinescu <ionela.voinescu@....com>,
        Mark Brown <broonie@...nel.org>,
        Amit Daniel Kachhap <amit.kachhap@....com>,
        Kristina Martsenko <kristina.martsenko@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: cpufeature: fix unused function warning

On Thu, Dec 03, 2020 at 11:32:11PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The __system_matches_cap() function is now only used in an #ifdef
> section:
> 
> arch/arm64/kernel/cpufeature.c:2649:13: error: unused function '__system_matches_cap' [-Werror,-Wunused-function]
> 
> Move it into that #ifdef section.
> 
> Fixes: 7cf283c7bd62 ("arm64: uaccess: remove redundant PAN toggling")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  arch/arm64/kernel/cpufeature.c | 36 ++++++++++++++++------------------
>  1 file changed, 17 insertions(+), 19 deletions(-)

Acked-by: Will Deacon <will@...nel.org>

We can probably go further and remove the helper altogether as I don't
think it really helps has_generic_auth(), but this should fix the warning.

Will