linux-kernel - Re: [PATCH net] xsk: Fix error return code in __xp_assign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fcb6b23a-4ecc-465e-6716-0725c9610da7@huawei.com>
Date:   Fri, 4 Dec 2020 18:18:59 +0800
From:   Zhang Changzhong <zhangchangzhong@...wei.com>
To:     Magnus Karlsson <magnus.karlsson@...il.com>
CC:     Björn Töpel <bjorn.topel@...el.com>,
        Magnus Karlsson <magnus.karlsson@...el.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] xsk: Fix error return code in __xp_assign_dev()

> 
> Good catch! My intention here by not setting err is that it should
> fall back to copy mode, which it does. The problem is that the
> force_zc flag is disregarded when err is not set (see exit code below)
> and your patch fixes that. If force_zc is set, we should exit out with
> an error, not fall back. Could you please write about this in your
> cover letter and send a v2?
> 

Thanks for the suggestion, I have sent the v2 patch, please take another look.

> BTW, what is the "Hulk Robot" that is in your Reported-by tag?

It's an auto tester, here is some information: https://lwn.net/Articles/804119/

> 
> Thank you: Magnus
> 
> err_unreg_xsk:
>         xp_disable_drv_zc(pool);
> err_unreg_pool:
>         if (!force_zc)
>                 err = 0; /* fallback to copy mode */
>         if (err)
>                 xsk_clear_pool_at_qid(netdev, queue_id);
>         return err;
> 
>>                 goto err_unreg_xsk;
>>         }
>>         pool->umem->zc = true;
>> --
>> 2.9.5
>>
> .
>