linux-kernel - Re: [PATCH] bus: fsl-mc: fix error return code in fsl_mc_object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b395e683-9ac1-55d1-319f-69a47d83d2aa@nxp.com>
Date:   Fri, 4 Dec 2020 12:44:20 +0200
From:   Laurentiu Tudor <laurentiu.tudor@....com>
To:     Zhang Changzhong <zhangchangzhong@...wei.com>,
        Stuart Yoder <stuyoder@...il.com>,
        Alexander Graf <agraf@...e.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bus: fsl-mc: fix error return code in
 fsl_mc_object_allocate()



On 12/4/2020 10:02 AM, Zhang Changzhong wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
> 
> Fixes: 197f4d6a4a00 ("staging: fsl-mc: fsl-mc object allocator driver")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>

Acked-by: Laurentiu Tudor <laurentiu.tudor@....com>

---
Best Regards, Laurentiu

> ---
>  drivers/bus/fsl-mc/fsl-mc-allocator.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bus/fsl-mc/fsl-mc-allocator.c b/drivers/bus/fsl-mc/fsl-mc-allocator.c
> index e71a6f5..2d7c764 100644
> --- a/drivers/bus/fsl-mc/fsl-mc-allocator.c
> +++ b/drivers/bus/fsl-mc/fsl-mc-allocator.c
> @@ -292,8 +292,10 @@ int __must_check fsl_mc_object_allocate(struct fsl_mc_device *mc_dev,
>  		goto error;
>  
>  	mc_adev = resource->data;
> -	if (!mc_adev)
> +	if (!mc_adev) {
> +		error = -EINVAL;
>  		goto error;
> +	}
>  
>  	mc_adev->consumer_link = device_link_add(&mc_dev->dev,
>  						 &mc_adev->dev,
>