linux-kernel - Re: [PATCH] firmware: tegra: bpmp: fix T234 build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <X8oZWMhARPcieFW7@ulmo>
Date:   Fri, 4 Dec 2020 12:11:20 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Jonathan Hunter <jonathanh@...dia.com>,
        Arnd Bergmann <arnd@...db.de>, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: tegra: bpmp: fix T234 build failure

On Fri, Dec 04, 2020 at 12:06:20AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> When only Tegra 234 is enabled, the bpmp driver fails
> to build:
> 
> drivers/firmware/tegra/bpmp.c:861:51: error: 'tegra186_soc' undeclared here (not in a function)
>   861 |  { .compatible = "nvidia,tegra186-bpmp", .data = &tegra186_soc },
>       |                                                   ^~~~~~~~~~~~
> 
> Fix the #ifdef statement to match the location in which this
> symbol is used.
> 
> Fixes: 0ebdf11699d0 ("firmware: tegra: Enable BPMP support on Tegra234")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/firmware/tegra/Makefile       | 1 +
>  drivers/firmware/tegra/bpmp-private.h | 3 ++-
>  drivers/firmware/tegra/bpmp.c         | 3 ++-
>  3 files changed, 5 insertions(+), 2 deletions(-)

Sigh... I wonder if I should just give up and eliminate all
ARCH_TEGRA_XYZ_SOC options. There's not a lot that we gain by keeping
them around and most people will be building multi-platform
configurations anyway, so there's very little point to it.

Anyway, this looks good, so:

Acked-by: Thierry Reding <treding@...dia.com>

Let me know if you'd prefer me to pick this up and send as a follow-up
pull request for Tegra.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)