linux-kernel - Re: [PATCH 1/2] MIPS: Don't round up kernel sections size for memblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Dec 2020 13:09:32 +0100
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Alexander A Sverdlin <alexander.sverdlin@...ia.com>
Cc:     linux-mips@...r.kernel.org, Paul Burton <paulburton@...nel.org>,
        Leonid Rosenboim <lrosenboim@...iumnetworks.com>,
        Corey Minyard <cminyard@...sta.com>,
        linux-kernel@...r.kernel.org,
        Serge Semin <fancer.lancer@...il.com>,
        "Maciej W . Rozycki" <macro@...ux-mips.org>,
        Jinyang He <hejinyang@...ngson.cn>,
        Jiaxun Yang <jiaxun.yang@...goat.com>
Subject: Re: [PATCH 1/2] MIPS: Don't round up kernel sections size for
 memblock_add()

On Thu, Dec 03, 2020 at 01:36:48PM +0100, Alexander A Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin@...ia.com>
> 
> Linux doesn't own the memory immediately after the kernel image. On Octeon
> bootloader places a shared structure right close after the kernel _end,
> refer to "struct cvmx_bootinfo *octeon_bootinfo" in cavium-octeon/setup.c.
> 
> If check_kernel_sections_mem() rounds the PFNs up, first memblock_alloc()
> inside early_init_dt_alloc_memory_arch() <= device_tree_init() returns
> memory block overlapping with the above octeon_bootinfo structure, which
> is being overwritten afterwards.
> 
> Fixes: a94e4f24ec83 ("MIPS: init: Drop boot_mem_map")
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@...ia.com>
> ---
>  arch/mips/kernel/setup.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]