linux-kernel - Re: [PATCH] mm: migrate: remove unused parameter in migrate_vma_insert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <03b7c070-f23e-cfb0-3252-e85c3140d3f0@redhat.com>
Date:   Fri, 4 Dec 2020 14:02:23 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Lee Bruce <starzhangzsd@...il.com>, akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: migrate: remove unused parameter in
 migrate_vma_insert_page()

On 04.12.20 12:54, Lee Bruce wrote:
> From 810f69c5438c66aafccf18ba8f43b99b64b85237 Mon Sep 17 00:00:00 2001
> From: Stephen Zhang <starzhangzsd@...il.com <mailto:starzhangzsd@...il.com>>
> Date: Fri, 4 Dec 2020 16:32:38 +0800
> Subject: [PATCH] mm: migrate: remove unused parameter in
>  migrate_vma_insert_page()
> 
> "dst" parameter to migrate_vma_insert_page() is not used anymore.
> 
> Signed-off-by: Stephen Zhang <starzhangzsd@...il.com
> <mailto:starzhangzsd@...il.com>>
> ---
>  mm/migrate.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/migrate.c b/mm/migrate.c
> index 4385f2f..ee5e612 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -2894,8 +2894,7 @@ int migrate_vma_setup(struct migrate_vma *args)
>  static void migrate_vma_insert_page(struct migrate_vma *migrate,
>      unsigned long addr,
>      struct page *page,
> -    unsigned long *src,
> -    unsigned long *dst)
> +    unsigned long *src)
>  {
>   struct vm_area_struct *vma = migrate->vma;
>   struct mm_struct *mm = vma->vm_mm;
> @@ -3056,8 +3055,7 @@ void migrate_vma_pages(struct migrate_vma *migrate)
>   mmu_notifier_invalidate_range_start(&range);
>   }
>   migrate_vma_insert_page(migrate, addr, newpage,
> - &migrate->src[i],
> - &migrate->dst[i]);
> + &migrate->src[i]);
>   continue;
>   }
>  
> -- 
> 1.8.3.1
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb