linux-kernel - Re: [PATCH v2 2/8] earlycon: simplify earlycon-table implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <X8pLYsprqsJMYanf@kroah.com>
Date:   Fri, 4 Dec 2020 15:44:50 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     Rob Herring <robh+dt@...nel.org>, Jessica Yu <jeyu@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Frank Rowand <frowand.list@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        David Miller <davem@...emloft.net>,
        Jakub Jelinek <jakub@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Steven Rostedt <rostedt@...dmis.org>,
        Daniel Kurtz <djkurtz@...omium.org>,
        linux-arch@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/8] earlycon: simplify earlycon-table implementation

On Fri, Dec 04, 2020 at 03:03:45PM +0100, Johan Hovold wrote:
> Greg,
> 
> On Mon, Nov 23, 2020 at 11:23:13AM +0100, Johan Hovold wrote:
> > Instead of using the array-of-pointers trick to avoid having gcc mess up
> > the earlycon array stride, specify type alignment when declaring entries
> > to prevent gcc from increasing alignment.
> > 
> > This is essentially an alternative (one-line) fix to the problem
> > addressed by commit dd709e72cb93 ("earlycon: Use a pointer table to fix
> > __earlycon_table stride").
> > 
> > gcc can increase the alignment of larger objects with static extent as
> > an optimisation, but this can be suppressed by using the aligned
> > attribute when declaring variables.
> > 
> > Note that we have been relying on this behaviour for kernel parameters
> > for 16 years and it indeed hasn't changed since the introduction of the
> > aligned attribute in gcc-3.1.
> > 
> > Signed-off-by: Johan Hovold <johan@...nel.org>
> 
> Could you pick this one up for 5.11?

Sure, will pick this and patch 1/8 up now, thanks for the prod.

greg k-h