linux-kernel - Re: [PATCH] media: mtk-vcodec: add remoteproc dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a3e+22WiJuV6APJ+vRZjPsbZw+=recE2dje_gjtfQ3gWA@mail.gmail.com>
Date:   Fri, 4 Dec 2020 16:41:35 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     Alexandre Courbot <acourbot@...omium.org>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Yunfei Dong <yunfei.dong@...iatek.com>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Tiffany Lin <tiffany.lin@...iatek.com>,
        Arnd Bergmann <arnd@...db.de>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Helen Koike <helen.koike@...labora.com>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] media: mtk-vcodec: add remoteproc dependency

On Fri, Dec 4, 2020 at 9:26 AM Alexandre Courbot <acourbot@...omium.org> wrote:
>
> On Fri, Dec 4, 2020 at 8:15 AM Arnd Bergmann <arnd@...nel.org> wrote:
> >
> > From: Arnd Bergmann <arnd@...db.de>
> >
> > The SCP firmware can only be built if CONFIG_REMOTEPROC is
> > enabled:
> >
> > WARNING: unmet direct dependencies detected for MTK_SCP
> >   Depends on [n]: REMOTEPROC [=n] && (ARCH_MEDIATEK [=y] || COMPILE_TEST [=y])
> >   Selected by [y]:
> >   - VIDEO_MEDIATEK_VCODEC [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && V4L_MEM2MEM_DRIVERS [=y] && (MTK_IOMMU [=y] || COMPILE_TEST [=y]) && VIDEO_DEV [=y] && VIDEO_V4L2 [=y] && (ARCH_MEDIATEK [=y] || COMPILE_TEST [=y])
>
> Despite setting these same options I cannot reproduce this warning on
> a merge of master + media. Which tree are you using?

Sorry about the noise. I was testing this on earlier this week on v5.10-rc5,
but your commit 2da185d6fe96 ("media: mtk-vcodec: fix build breakage
when one of VPU or SCP is enabled") has made it into mainline in the
meantime and fixed the issue.

I had rebased my patches onto linux-next before sending them out to
make sure everything still works, but did not check that it was still
broken without it. Clearly my patch must have conflicted with yours
during the rebase, which should have told me to recheck.

Please disregard my fix.

       Arnd