linux-kernel - Re: [PATCH] soundwire: intel: fix another unused-function warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Dec 2020 17:48:47 -0600
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Arnd Bergmann <arnd@...nel.org>, Vinod Koul <vkoul@...nel.org>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Sanyog Kale <sanyog.r.kale@...el.com>,
        Rander Wang <rander.wang@...el.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soundwire: intel: fix another unused-function warning



On 12/3/20 5:04 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Without CONFIG_PM, there is another warning about an unused function:
> 
> drivers/soundwire/intel.c:530:12: error: 'intel_link_power_down' defined but not used [-Werror=unused-function]
> 
> After a previous fix, the driver already uses both an #ifdef and
> a __maybe_unused annotation but still gets it wrong. Remove the
> ifdef and instead use __maybe_unused consistently to avoid the
> problem for good.
> 
> Fixes: f046b2334083 ("soundwire: intel: fix intel_suspend/resume defined but not used warning")
> Fixes: ebf878eddbb4 ("soundwire: intel: add pm_runtime support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks for the patch Arnd, indeed that's a miss.

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>

> ---
>   drivers/soundwire/intel.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
> index 6a1e862b16c3..66adb258a425 100644
> --- a/drivers/soundwire/intel.c
> +++ b/drivers/soundwire/intel.c
> @@ -1585,8 +1585,6 @@ int intel_master_process_wakeen_event(struct platform_device *pdev)
>    * PM calls
>    */
>   
> -#ifdef CONFIG_PM
> -
>   static int __maybe_unused intel_suspend(struct device *dev)
>   {
>   	struct sdw_cdns *cdns = dev_get_drvdata(dev);
> @@ -1641,7 +1639,7 @@ static int __maybe_unused intel_suspend(struct device *dev)
>   	return 0;
>   }
>   
> -static int intel_suspend_runtime(struct device *dev)
> +static int __maybe_unused intel_suspend_runtime(struct device *dev)
>   {
>   	struct sdw_cdns *cdns = dev_get_drvdata(dev);
>   	struct sdw_intel *sdw = cdns_to_intel(cdns);
> @@ -1796,7 +1794,7 @@ static int __maybe_unused intel_resume(struct device *dev)
>   	return ret;
>   }
>   
> -static int intel_resume_runtime(struct device *dev)
> +static int __maybe_unused intel_resume_runtime(struct device *dev)
>   {
>   	struct sdw_cdns *cdns = dev_get_drvdata(dev);
>   	struct sdw_intel *sdw = cdns_to_intel(cdns);
> @@ -1969,8 +1967,6 @@ static int intel_resume_runtime(struct device *dev)
>   	return ret;
>   }
>   
> -#endif
> -
>   static const struct dev_pm_ops intel_pm = {
>   	SET_SYSTEM_SLEEP_PM_OPS(intel_suspend, intel_resume)
>   	SET_RUNTIME_PM_OPS(intel_suspend_runtime, intel_resume_runtime, NULL)
>