linux-kernel - Re: [PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 USB reset binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0cc54a35-7d70-8a2f-0c1f-da124136a66d@gmail.com>
Date:   Fri, 4 Dec 2020 08:32:17 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Rafał Miłecki <zajec5@...il.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        Rafał Miłecki <rafal@...ecki.pl>
Subject: Re: [PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 USB
 reset binding



On 12/4/2020 1:37 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@...ecki.pl>
> 
> Document binding of block responsible for initializing USB controllers
> (OHCI, EHCI, XHCI).
> 
> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>
> ---
>  .../reset/brcm,bcm4908-usb-reset.yaml         | 60 +++++++++++++++++++
>  1 file changed, 60 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/reset/brcm,bcm4908-usb-reset.yaml
> 
> diff --git a/Documentation/devicetree/bindings/reset/brcm,bcm4908-usb-reset.yaml b/Documentation/devicetree/bindings/reset/brcm,bcm4908-usb-reset.yaml
> new file mode 100644
> index 000000000000..31beb1c8f3cd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/brcm,bcm4908-usb-reset.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reset/brcm,bcm4908-usb-reset.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BCM4908 USB host controller reset
> +
> +description: >
> +  BCM4908 has a separated block controlling all USB controllers. It handles the
> +  whole setup process and takes care of initializing PHYs at the right time
> +  (state).
> +
> +maintainers:
> +  - Rafał Miłecki <rafal@...ecki.pl>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - brcm,bcm4908-usb-reset
> +
> +  reg:
> +    maxItems: 1
> +
> +  resets:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +
> +  phys:
> +    minItems: 2
> +    maxItems: 2
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +
> +  phy-names:
> +    items:
> +      - const: usb2
> +      - const: usb3
> +
> +  "#reset-cells":
> +    const: 0
> +
> +required:
> +  - compatible
> +  - reg
> +  - phys
> +  - phy-names
> +  - "#reset-cells"
> +
> +additionalProperties: true
> +
> +examples:
> +  - |
> +    reset-controller@...0c200 {
> +        compatible = "brcm,bcm4908-usb-reset";
> +        reg = <0x8000c200 0x100>;
> +
> +        phys = <&usb2_phy>, <&usb3_phy>;
> +        phy-names = "usb2", "usb3";

This looks quite unusual, usually the *HCI controllers would be
consumers of the PHY and the PHY may be a consumer of the reset controller.

(still going through my emails have not fully read your separate email
on the topic, so pardon me if this is being discussed twice).
-- 
Florian