linux-kernel - Re: [PATCH] [v2] phy: mediatek: allow compile-testing the hdmi phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 5 Dec 2020 13:21:20 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Chunfeng Yun <chunfeng.yun@...iatek.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        CK Hu <ck.hu@...iatek.com>,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Colin Ian King <colin.king@...onical.com>,
        Tiezhu Yang <yangtiezhu@...ngson.cn>,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] phy: mediatek: allow compile-testing the hdmi phy

On 04-12-20, 14:56, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Compile-testing the DRM_MEDIATEK_HDMI driver shows two missing
> dependencies, one results in a link failure:
> 
> arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi.o: in function `mtk_hdmi_phy_probe':
> phy-mtk-hdmi.c:(.text+0xd8): undefined reference to `__clk_get_name'
> arm-linux-gnueabi-ld: phy-mtk-hdmi.c:(.text+0x12c): undefined reference to `devm_clk_register'
> arm-linux-gnueabi-ld: phy-mtk-hdmi.c:(.text+0x250): undefined reference to `of_clk_add_provider'
> arm-linux-gnueabi-ld: phy-mtk-hdmi.c:(.text+0x298): undefined reference to `of_clk_src_simple_get'
> 
> The other one is a harmless warning:
> 
> WARNING: unmet direct dependencies detected for PHY_MTK_HDMI
>   Depends on [n]: ARCH_MEDIATEK [=n] && OF [=y]
>   Selected by [y]:
>   - DRM_MEDIATEK_HDMI [=y] && HAS_IOMEM [=y] && DRM_MEDIATEK [=y]
> 
> Fix these by adding dependencies on CONFIG_OF and CONFIG_COMMON_CLK.
> With that done, there is also no reason against adding
> CONFIG_COMPILE_TEST.

Applied, thanks

-- 
~Vinod