[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20201205080941.GX8403@vkoul-mobl>
Date: Sat, 5 Dec 2020 13:39:41 +0530
From: Vinod Koul <vkoul@...nel.org>
To: 周琰杰 (Zhou Yanjie)
<zhouyanjie@...yeetech.com>
Cc: balbi@...nel.org, gregkh@...uxfoundation.org,
mturquette@...libre.com, sboyd@...nel.org, robh+dt@...nel.org,
kishon@...com, linux-clk@...r.kernel.org,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, dongsheng.qiu@...enic.com,
aric.pzqi@...enic.com, rick.tyliu@...enic.com,
yanfei.li@...enic.com, sernia.zhou@...mail.com,
zhenwenjin@...il.com, paul@...pouillou.net
Subject: Re: [PATCH v9 0/3] Use the generic PHY framework for Ingenic USB PHY.
On 16-11-20, 22:19, 周琰杰 (Zhou Yanjie) wrote:
> v3->v4:
> Only add new generic-PHY driver, without removing the old one. Because the
> jz4740-musb driver is not ready to use the generic PHY framework. When the
> jz4740-musb driver is modified to use the generic PHY framework, the old
> jz4770-phy driver can be "retired".
>
> v4->v5:
> 1.Add an extra blank line between "devm_of_phy_provider_register" and "return".
> 2.Remove unnecessary "phy_set_drvdata".
> 3.Add Paul Cercueil's Reviewed-by.
>
> v5->v6:
> 1.Revert the removal of "phy_set_drvdata" in v5, removing "phy_set_drvdata" will
> cause a kernel panic on CI20.
> Reported-by: H. Nikolaus Schaller <hns@...delico.com>
> 2.Rewrite the macro definitions, replace the original code with "FIELD_PREP()"
> and "u32p_replace_bits()" according to Vinod Koul's suggestion.
>
> v6->v7:
> 1.Remove the stray tab character.
> 2.Remove unnecessary "platform_set_drvdata".
> 3.Remove the "dev" field in priv structure, and use &phy->dev instead.
>
> v7->v8:
> Add support for Ingenic JZ4775 SoC and X2000 SoC.
>
> v8->v9:
> Correct the path errors in "ingenic,phy-usb.yaml" and "ingenic,cgu.yaml".
Applied, thanks
--
~Vinod
Powered by blists - more mailing lists