linux-kernel - Re: [PATCH] drivers/pcmcia: Fix error return code in electra_cf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <X8tLnWhuUhTjwnH4@light.dominikbrodowski.net>
Date:   Sat, 5 Dec 2020 09:58:05 +0100
From:   Dominik Brodowski <linux@...inikbrodowski.net>
To:     Wei Li <liwei391@...wei.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Olof Johansson <olof@...om.net>, linux-kernel@...r.kernel.org,
        guohanjun@...wei.com
Subject: Re: [PATCH] drivers/pcmcia: Fix error return code in
 electra_cf_probe()

Am Tue, Nov 24, 2020 at 03:00:40PM +0800 schrieb Wei Li:
> When it fails to call of_get_property(), it just jumps to 'fail1',
> while the 'status' which will be returned is not updated.
> 
> Fixes: 2b571a066a2f ("pcmcia: CompactFlash driver for PA Semi Electra boards")
> Signed-off-by: Wei Li <liwei391@...wei.com>

Thnaks for the patch. However, this issue is already fixed by
commit f15480e947d4 ("pcmcia/electra_cf: Fix some return values in 'electra_cf_probe()'
in case of error")
in pcmcia-next.

Thanks,
	Dominik