linux-kernel - RE: [PATCH v4 0/8] Refine error history and introduce event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1607170053.3580.2.camel@mtkswgap22>
Date:   Sat, 5 Dec 2020 20:07:33 +0800
From:   Stanley Chu <stanley.chu@...iatek.com>
To:     Avri Altman <Avri.Altman@....com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "alim.akhtar@...sung.com" <alim.akhtar@...sung.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "bvanassche@....org" <bvanassche@....org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kuohong Wang (王????) 
        <kuohong.wang@...iatek.com>,
        "Peter Wang (王信友)" 
        <peter.wang@...iatek.com>,
        Chun-Hung Wu (巫?E宏) 
        <Chun-hung.Wu@...iatek.com>,
        "Andy Teng (??如宏)" 
        <Andy.Teng@...iatek.com>,
        Chaotian Jing (井朝天) 
        <Chaotian.Jing@...iatek.com>,
        CC Chou (周志杰) 
        <cc.chou@...iatek.com>,
        Jiajie Hao (郝加节) 
        <jiajie.hao@...iatek.com>,
        Alice Chao (?w??均) 
        <Alice.Chao@...iatek.com>,
        Huadian Liu (刘华典) 
        <huadian.liu@...iatek.com>
Subject: RE: [PATCH v4 0/8] Refine error history and introduce event_notify
 vop

Hi Avri,

On Sat, 2020-12-05 at 16:05 +0800, Avri Altman wrote:
> > 
> > Hi Stanley,
> > Will you split this series to 3 separate series:
> > Phy initialization cleanup, Error history, and event notification?
> > As those 3 aren't really connected?
> > 
> > Please maintain Can's reviewed-by tag for the error history patches,
> > And add mine for the phy initialization, so Martin can pick those.
> And for the new event notification vop of course.  Sorry.

Thanks for the review!

Sure I would separate it to 2 series
1. Cleanup phy_initialization
2. Error history and event notification since these patches are strongly
related

Please review my new posted series and feel free to provide any further
suggestion.

Thanks,
Stanley Chu 

> 
> Thanks,
> Avri
> 
> > 
> > Thanks,
> > Avri
> > 
> > >
> > > Hi,
> > > This series refines error history functions, do vop cleanups and introduce a
> > > new event_notify vop to allow vendor to get notification of important
> > > events.
> > >
> > > Changes since v3:
> > >   - Fix build warning in patch [8/8]
> > >
> > > Changes since v2:
> > >   - Add patches for vop cleanups
> > >   - Introduce phy_initialization helper and replace direct invoking in ufs-cdns
> > > and ufs-dwc by the helper
> > >   - Introduce event_notify vop implemntation in ufs-mediatek
> > >
> > > Changes since v1:
> > >   - Change notify_event() to event_notify() to follow vop naming covention
> > >
> > > Stanley Chu (8):
> > >   scsi: ufs: Remove unused setup_regulators variant function
> > >   scsi: ufs: Introduce phy_initialization helper
> > >   scsi: ufs-cdns: Use phy_initialization helper
> > >   scsi: ufs-dwc: Use phy_initialization helper
> > >   scsi: ufs: Add error history for abort event in UFS Device W-LUN
> > >   scsi: ufs: Refine error history functions
> > >   scsi: ufs: Introduce event_notify variant function
> > >   scsi: ufs-mediatek: Introduce event_notify implementation
> > >
> > >  drivers/scsi/ufs/cdns-pltfrm.c        |   3 +-
> > >  drivers/scsi/ufs/ufs-mediatek-trace.h |  37 ++++++++
> > >  drivers/scsi/ufs/ufs-mediatek.c       |  12 +++
> > >  drivers/scsi/ufs/ufshcd-dwc.c         |  11 +--
> > >  drivers/scsi/ufs/ufshcd.c             | 132 ++++++++++++++------------
> > >  drivers/scsi/ufs/ufshcd.h             | 100 +++++++++----------
> > >  6 files changed, 175 insertions(+), 120 deletions(-)
> > >  create mode 100644 drivers/scsi/ufs/ufs-mediatek-trace.h
> > >
> > > --
> > > 2.18.0
>