linux-kernel - Re: [PATCH] i2c: mlxbf: select CONFIG_I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 5 Dec 2020 14:49:07 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Vadim Pasternak <vadimp@...lanox.com>,
        Khalil Blaiech <kblaiech@...lanox.com>,
        Arnd Bergmann <arnd@...db.de>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Jean Delvare <jdelvare@...e.de>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: mlxbf: select CONFIG_I2C_SLAVE

On Thu, Dec 03, 2020 at 11:32:50PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> If this is not enabled, the interfaces used in this driver do not work:
> 
> drivers/i2c/busses/i2c-mlxbf.c:1888:3: error: implicit declaration of function 'i2c_slave_event' [-Werror,-Wimplicit-function-declaration]
>                 i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
>                 ^
> drivers/i2c/busses/i2c-mlxbf.c:1888:26: error: use of undeclared identifier 'I2C_SLAVE_WRITE_REQUESTED'
>                 i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
>                                        ^
> drivers/i2c/busses/i2c-mlxbf.c:1890:32: error: use of undeclared identifier 'I2C_SLAVE_WRITE_RECEIVED'
>                 ret = i2c_slave_event(slave, I2C_SLAVE_WRITE_RECEIVED,
>                                              ^
> drivers/i2c/busses/i2c-mlxbf.c:1892:26: error: use of undeclared identifier 'I2C_SLAVE_STOP'
>                 i2c_slave_event(slave, I2C_SLAVE_STOP, &value);
>                                        ^
> 
> Fixes: b5b5b32081cd ("i2c: mlxbf: I2C SMBus driver for Mellanox BlueField SoC")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied to for-current, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)