linux-kernel - Re: [PATCH 3/9] mm: memcontrol: convert kernel stack account to byte-sized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X8uUv2TJ7CQ/mijD@kroah.com>
Date:   Sat, 5 Dec 2020 15:10:07 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Muchun Song <songmuchun@...edance.com>
Cc:     rafael@...nel.org, adobriyan@...il.com, akpm@...ux-foundation.org,
        hannes@...xchg.org, mhocko@...nel.org, vdavydov.dev@...il.com,
        hughd@...gle.com, will@...nel.org, guro@...com, rppt@...nel.org,
        tglx@...utronix.de, esyr@...hat.com, peterx@...hat.com,
        krisman@...labora.com, surenb@...gle.com, avagin@...nvz.org,
        elver@...gle.com, rdunlap@...radead.org, iamjoonsoo.kim@....com,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-mm@...ck.org, cgroups@...r.kernel.org
Subject: Re: [PATCH 3/9] mm: memcontrol: convert kernel stack account to
 byte-sized

On Sat, Dec 05, 2020 at 09:02:18PM +0800, Muchun Song wrote:
> The kernel stack account is the only one that counts in KiB.
> This patch convert it from KiB to byte.
> 
> Signed-off-by: Muchun Song <songmuchun@...edance.com>
> ---
>  drivers/base/node.c    | 2 +-
>  fs/proc/meminfo.c      | 2 +-
>  include/linux/mmzone.h | 2 +-
>  kernel/fork.c          | 8 ++++----
>  mm/memcontrol.c        | 2 +-
>  mm/page_alloc.c        | 2 +-
>  mm/vmstat.c            | 4 ++--
>  7 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/base/node.c b/drivers/base/node.c
> index 6ffa470e2984..855886a6ba0e 100644
> --- a/drivers/base/node.c
> +++ b/drivers/base/node.c
> @@ -446,7 +446,7 @@ static ssize_t node_read_meminfo(struct device *dev,
>  			     nid, K(node_page_state(pgdat, NR_FILE_MAPPED)),
>  			     nid, K(node_page_state(pgdat, NR_ANON_MAPPED)),
>  			     nid, K(i.sharedram),
> -			     nid, node_page_state(pgdat, NR_KERNEL_STACK_KB),
> +			     nid, node_page_state(pgdat, NR_KERNEL_STACK_B) / 1024,

Did you just change the units of a userspace-visable file without
updating the documentation?

If not, how is this working?

thanks,

greg k-h