[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201205143001.GC2420376@lunn.ch>
Date: Sat, 5 Dec 2020 15:30:01 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Claudiu Beznea <claudiu.beznea@...rochip.com>
Cc: davem@...emloft.net, kuba@...nel.org, robh+dt@...nel.org,
nicolas.ferre@...rochip.com, linux@...linux.org.uk,
paul.walmsley@...ive.com, palmer@...belt.com, yash.shah@...ive.com,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 3/7] net: macb: unprepare clocks in case of failure
On Fri, Dec 04, 2020 at 02:34:17PM +0200, Claudiu Beznea wrote:
> Unprepare clocks in case of any failure in fu540_c000_clk_init().
Hi Claudiu
Nice patchset. Simple to understand.
>
> +err_disable_clocks:
> + clk_disable_unprepare(*tx_clk);
> + clk_disable_unprepare(*hclk);
> + clk_disable_unprepare(*pclk);
> + clk_disable_unprepare(*rx_clk);
> + clk_disable_unprepare(*tsu_clk);
This looks correct, but it would be more symmetrical to add a
macb_clk_uninit()
function for the four main clocks. I'm surprised it does not already
exist.
Andrew
Powered by blists - more mailing lists