linux-kernel - Re: [PATCH] phy: mediatek: statify mtk_hdmi_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAOTY_-_X98x=DeGLnSRDcZ+9wfpW2-EzpqJLQxDJ-UGoYaONw@mail.gmail.com>
Date:   Sun, 6 Dec 2020 00:21:48 +0800
From:   Chun-Kuang Hu <chunkuang.hu@...nel.org>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Chunfeng Yun <chunfeng.yun@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        DRI Development <dri-devel@...ts.freedesktop.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy: mediatek: statify mtk_hdmi_phy_driver

Hi, Vinod:

Vinod Koul <vkoul@...nel.org> 於 2020年12月5日 週六 下午5:11寫道：
>
> mtk_hdmi_phy_driver is not declared as static, so statify it.
>
> drivers/phy/mediatek/phy-mtk-hdmi.c:204:24: warning: symbol 'mtk_hdmi_phy_driver' was not declared. Should it be static?
>

Acked-by: Chun-Kuang Hu <chunkuang.hu@...nel.org>

> Signed-off-by: Vinod Koul <vkoul@...nel.org>
> ---
>  drivers/phy/mediatek/phy-mtk-hdmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/mediatek/phy-mtk-hdmi.c b/drivers/phy/mediatek/phy-mtk-hdmi.c
> index 47c029d4b270..c5c61f5a9ea0 100644
> --- a/drivers/phy/mediatek/phy-mtk-hdmi.c
> +++ b/drivers/phy/mediatek/phy-mtk-hdmi.c
> @@ -201,7 +201,7 @@ static const struct of_device_id mtk_hdmi_phy_match[] = {
>         {},
>  };
>
> -struct platform_driver mtk_hdmi_phy_driver = {
> +static struct platform_driver mtk_hdmi_phy_driver = {
>         .probe = mtk_hdmi_phy_probe,
>         .driver = {
>                 .name = "mediatek-hdmi-phy",
> --
> 2.26.2
>