linux-kernel - Re: [PATCH] acpi: resource: Use AE_ABORT_METHOD to terminate acpi_dev_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2246133.BJYN6MDhT9@kreacher>
Date:   Sat, 05 Dec 2020 16:21:51 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Daniel Scally <djrscally@...il.com>
Cc:     linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        lenb@...nel.org, mika.westerberg@...ux.intel.com
Subject: Re: [PATCH] acpi: resource: Use AE_ABORT_METHOD to terminate acpi_dev_get_resources()

On Friday, December 4, 2020 1:27:40 AM CET Daniel Scally wrote:
> Switching this function to AE_CTRL_TERMINATE broke the documented
> behaviour of acpi_dev_get_resources() - AE_CTRL_TERMINATE does not, in
> fact, terminate the resource walk because acpi_walk_resource_buffer()
> ignores it (specifically converting it to AE_OK), referring to that
> value as "an OK termination by the user function". This means that
> acpi_dev_get_resources() does not abort processing when the preproc
> function returns a negative value.
> 
> Revert to AE_ABORT_METHOD
> 
> Fixes: 8a66790b7850 ("ACPI / resources: Use AE_CTRL_TERMINATE to terminate resources walks")
> Signed-off-by: Daniel Scally <djrscally@...il.com>

This is simply a revert of the above commit, so it would be better to present
it as a revert explicitly.

> ---
>  drivers/acpi/resource.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index ad04824ca3ba..f2f5f1dc7c61 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -541,7 +541,7 @@ static acpi_status acpi_dev_process_resource(struct acpi_resource *ares,
>  		ret = c->preproc(ares, c->preproc_data);
>  		if (ret < 0) {
>  			c->error = ret;
> -			return AE_CTRL_TERMINATE;
> +			return AE_ABORT_METHOD;
>  		} else if (ret > 0) {
>  			return AE_OK;
>  		}
>