linux-kernel - Re: [PATCH] platform/chrome: cros_ec_typec: Tolerate unrecognized mux flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACeCKadt_=4+Xc+8OojSg7isXgL2dhfnaUHCMKhtDe_HwPQwdQ@mail.gmail.com>
Date:   Fri, 4 Dec 2020 17:09:19 -0800
From:   Prashant Malani <pmalani@...omium.org>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Keith Short <keithshort@...omium.org>,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>
Subject: Re: [PATCH] platform/chrome: cros_ec_typec: Tolerate unrecognized mux flags

Friendly ping. If there are not other reservations, can we pick this
patch? It doesn't depend on any other patch series.

Thanks,

On Thu, Nov 19, 2020 at 11:32 PM Heikki Krogerus
<heikki.krogerus@...ux.intel.com> wrote:
>
> On Thu, Nov 05, 2020 at 06:03:05PM -0800, Prashant Malani wrote:
> > On occasion, the Chrome Embedded Controller (EC) can send a mux
> > configuration which doesn't map to a particular data mode. For instance,
> > dedicated Type C chargers, when connected, may cause only
> > USB_PD_MUX_POLARITY_INVERTED to be set. This is a valid flag combination
> > and should not lead to a driver abort.
> >
> > Modify the mux configuration handling to not return an error when an
> > unrecognized mux flag combination is encountered. Concordantly, make the
> > ensuing print a debug level print so as to not pollute the kernel logs.
> >
> > Cc: Keith Short <keithshort@...omium.org>
> > Signed-off-by: Prashant Malani <pmalani@...omium.org>
>
> FWIW:
>
> Acked-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
>
> > ---
> >  drivers/platform/chrome/cros_ec_typec.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> > index ce031a10eb1b..5b8db02ab84a 100644
> > --- a/drivers/platform/chrome/cros_ec_typec.c
> > +++ b/drivers/platform/chrome/cros_ec_typec.c
> > @@ -537,10 +537,9 @@ static int cros_typec_configure_mux(struct cros_typec_data *typec, int port_num,
> >               port->state.mode = TYPEC_STATE_USB;
> >               ret = typec_mux_set(port->mux, &port->state);
> >       } else {
> > -             dev_info(typec->dev,
> > -                      "Unsupported mode requested, mux flags: %x\n",
> > -                      mux_flags);
> > -             ret = -ENOTSUPP;
> > +             dev_dbg(typec->dev,
> > +                     "Unrecognized mode requested, mux flags: %x\n",
> > +                     mux_flags);
> >       }
> >
> >       return ret;
> > --
> > 2.29.1.341.ge80a0c044ae-goog
>
> thanks,
>
> --
> heikki