linux-kernel - Re: [char-misc-next 13/13] mei: virtio: virtualization frontend driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201205143909-mutt-send-email-mst@kernel.org>
Date:   Sat, 5 Dec 2020 14:40:10 -0500
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     "Winkler, Tomas" <tomas.winkler@...el.com>,
        "Usyskin, Alexander" <alexander.usyskin@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Wang, Yu1" <yu1.wang@...el.com>,
        "Liu, Shuo A" <shuo.a.liu@...el.com>,
        "virtio-dev@...ts.oasis-open.org" <virtio-dev@...ts.oasis-open.org>
Subject: Re: [char-misc-next 13/13] mei: virtio: virtualization frontend
 driver

On Thu, Dec 03, 2020 at 11:01:45PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Dec 03, 2020 at 04:51:10PM -0500, Michael S. Tsirkin wrote:
> > On Wed, Nov 25, 2020 at 09:18:04PM +0000, Winkler, Tomas wrote:
> > > > 
> > > > On Tue, Aug 18, 2020 at 02:51:47PM +0300, Tomas Winkler wrote:
> > > > > +#ifndef VIRTIO_ID_MEI
> > > > > +#define VIRTIO_ID_MEI 0xFFFE /* virtio mei */ #endif
> > > > 
> > > > Just noticed now that this driver landed upstream.  Can I ask that you guys
> > > > please register IDs with the virtio TC and not just pick a number at random?
> > > > In particular this is way outside allowed range.
> > > > 
> > > > IDs should also be listed in include/uapi/linux/virtio_ids.h
> > > > 
> > > > If people just pick random numbers like this collistions are unavoidable.
> > > > 
> > > > List of IDs is part of virtio spec, chapter "Device Types".
> > > > 
> > > > Please do this change now before this goes out to production!
> > > Okay,  this was assigned by ACRN, my impression was it's already registered.
> > > Will take care of.
> > > Thanks
> > > Tomas
> > 
> > Well nothing happened yet.
> > 
> > I think at this point we really should revert this patch before Linux is
> > released so in the next version the correct ID can be used instead of a reserved one.
> > Otherwise Linux will be stuck supporting this forever and will conflict
> > with hypervisors using this for what this range is for which is
> > experimental use.
> > 
> > Greg, any opinion on that?
> 
> I will be glad to revert it, what's the git commit id?

commit d162219c655c8cf8003128a13840d6c1e183fb80
Author: Tomas Winkler <tomas.winkler@...el.com>
Date:   Tue Aug 18 14:51:47 2020 +0300

    mei: virtio: virtualization frontend driver
    

I sent a revert on list in case it makes things easier,
but it's just a result of a plain git revert,
build-tested.


> thanks,
> 
> greg k-h