linux-kernel - Re: [BUG] SPI broken for SPI based panel drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201205205744.GD8578@amd>
Date:   Sat, 5 Dec 2020 21:57:44 +0100
From:   Pavel Machek <pavel@....cz>
To:     Sven Van Asbroeck <thesven73@...il.com>
Cc:     "H. Nikolaus Schaller" <hns@...delico.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Mark Brown <broonie@...nel.org>,
        kernel list <linux-kernel@...r.kernel.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Discussions about the Letux Kernel 
        <letux-kernel@...nphoenux.org>
Subject: Re: [BUG] SPI broken for SPI based panel drivers

On Mon 2020-11-30 15:13:02, Sven Van Asbroeck wrote:
> Hi Nikolaus, thank you for reaching out !
> 
> On Mon, Nov 30, 2020 at 2:06 PM H. Nikolaus Schaller <hns@...delico.com> wrote:
> >
> > But reverting your patch brings back the display. So it appears as if it does not
> > fix a breakage, rather breaks a previously working setup.
> 
> The patch in question fixes an important breakage: before the patch, literally
> hundreds of SPI drivers no longer worked - only if the SPI bus master
> driver was using gpio descriptors.
> 
> We knew that there was a chance that our fix would break something else.
> But hopefully "it fixes more than it breaks"

If the patch causes regression it will ultimately need to be
reverted... no matter how much it fixes.

									Pavel
-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)