lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAFBinCB-pSeN8rWrLz8doZKdeB=_sRL5osS7yF=UT6itcpXnnA@mail.gmail.com>
Date:   Sat, 5 Dec 2020 22:40:47 +0100
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     Amjad Ouled-Ameur <aouledameur@...libre.com>
Cc:     Kevin Hilman <khilman@...libre.com>,
        Felipe Balbi <balbi@...nel.org>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Philipp Zabel <p.zabel@...gutronix.de>,
        linux-amlogic@...ts.infradead.org,
        Jerome Brunet <jbrunet@...libre.com>
Subject: Re: [PATCH v2 3/3] phy: amlogic: meson8b-usb2: fix shared reset
 control use

On Tue, Dec 1, 2020 at 8:02 PM Amjad Ouled-Ameur
<aouledameur@...libre.com> wrote:
>
> Use reset_control_rearm() call if an error occurs in case
> phy_meson8b_usb2_power_on() fails after reset() has been called, or in
> case phy_meson8b_usb2_power_off() is called i.e the resource is no longer
> used and the reset line may be triggered again by other devices.
>
> reset_control_rearm() keeps use of triggered_count sane in the reset
> framework, use of reset_control_reset() on shared reset line should
> be balanced with reset_control_rearm().
>
> Signed-off-by: Amjad Ouled-Ameur <aouledameur@...libre.com>
> Reported-by: Jerome Brunet <jbrunet@...libre.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Tested-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com> #
on Odroid-C1+

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ