linux-kernel - Re: [PATCH v2] gpio: just plain warning when nonexisting gpio requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbG3ZSBCk_8QaP+7g5O-Otjrxv2VU3fXnsSuDDuQRMYyA@mail.gmail.com>
Date:   Sat, 5 Dec 2020 23:29:22 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     "Enrico Weigelt, metux IT consult" <info@...ux.net>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v2] gpio: just plain warning when nonexisting gpio requested

On Wed, Dec 2, 2020 at 2:37 PM Enrico Weigelt, metux IT consult
<info@...ux.net> wrote:

> From: Enrico Weigelt <info@...ux.net>
>
> When trying to export an nonexisting gpio ID, the kernel prints out a
> big warning w/ stacktrace, sounding like a huge problem. In fact it's
> a pretty normal situation, like file or device not found.
>
> So, just print a more relaxed warning instead.
>
> changes v2: drop defining pr_fmt()
>
> Signed-off-by: Enrico Weigelt <info@...ux.net>

Hm hm. It would mainly happen if someone was using the sysfs
ABI right? I don't mind if sysfs feels scary to use.

But I see it can happen for other code using the old GPIO
symbols so OK I applied it.

Yours,
Linus Walleij