lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 6 Dec 2020 09:56:47 +0000
From:   "Wan Mohamad, Wan Ahmad Zainie" 
        <wan.ahmad.zainie.wan.mohamad@...el.com>
To:     Serge Semin <Sergey.Semin@...kalelectronics.ru>,
        "Nyman, Mathias" <mathias.nyman@...el.com>,
        Felipe Balbi <balbi@...nel.org>,
        "Krzysztof Kozlowski" <krzk@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Chunfeng Yun <chunfeng.yun@...iatek.com>
CC:     Serge Semin <fancer.lancer@...il.com>,
        Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Manu Gautam <mgautam@...eaurora.org>,
        Roger Quadros <rogerq@...com>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        narmstrong <narmstrong@...libre.com>,
        Kevin Hilman <khilman@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-snps-arc@...ts.infradead.org" 
        <linux-snps-arc@...ts.infradead.org>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v5 19/19] dt-bindings: usb: intel,keembay-dwc3: Validate
 DWC3 sub-node

Hi Serge.

> -----Original Message-----
> From: Serge Semin <Sergey.Semin@...kalelectronics.ru>
> Sent: Saturday, December 5, 2020 11:24 PM
> To: Nyman, Mathias <mathias.nyman@...el.com>; Felipe Balbi
> <balbi@...nel.org>; Krzysztof Kozlowski <krzk@...nel.org>; Greg Kroah-
> Hartman <gregkh@...uxfoundation.org>; Rob Herring
> <robh+dt@...nel.org>; Chunfeng Yun <chunfeng.yun@...iatek.com>;
> Wan Mohamad, Wan Ahmad Zainie
> <wan.ahmad.zainie.wan.mohamad@...el.com>
> Cc: Serge Semin <Sergey.Semin@...kalelectronics.ru>; Serge Semin
> <fancer.lancer@...il.com>; Alexey Malahov
> <Alexey.Malahov@...kalelectronics.ru>; Pavel Parkhomenko
> <Pavel.Parkhomenko@...kalelectronics.ru>; Andy Gross
> <agross@...nel.org>; Bjorn Andersson <bjorn.andersson@...aro.org>;
> Manu Gautam <mgautam@...eaurora.org>; Roger Quadros
> <rogerq@...com>; Lad Prabhakar <prabhakar.mahadev-
> lad.rj@...renesas.com>; Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@...esas.com>; narmstrong
> <narmstrong@...libre.com>; Kevin Hilman <khilman@...libre.com>;
> Martin Blumenstingl <martin.blumenstingl@...glemail.com>; linux-arm-
> kernel@...ts.infradead.org; linux-snps-arc@...ts.infradead.org; linux-
> mips@...r.kernel.org; linuxppc-dev@...ts.ozlabs.org; linux-
> usb@...r.kernel.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH v5 19/19] dt-bindings: usb: intel,keembay-dwc3: Validate
> DWC3 sub-node
> 
> Intel Keem Bay DWC3 compatible DT nodes are supposed to have a DWC
> USB3 compatible sub-node to describe a fully functioning USB interface. Let's
> use the available DWC USB3 DT schema to validate the Qualcomm DWC3 sub-
> nodes.
> 
> Note since the generic DWC USB3 DT node is supposed to be named as
> generic USB HCD ("^usb(@.*)?") one we have to accordingly fix the sub-
> nodes name regexp and fix the DT node example.
> 
> Signed-off-by: Serge Semin <Sergey.Semin@...kalelectronics.ru>

LGTM. With minor change to fix the typo above, Qualcomm to Intel
Keem Bay,
Acked-by: Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@...el.com>

> 
> ---
> 
> Changelog v5:
> - This is a new patch created for the new Intel Keem Bay bindings file,
>   which has been added just recently.
> ---
>  .../devicetree/bindings/usb/intel,keembay-dwc3.yaml      | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/intel,keembay-
> dwc3.yaml b/Documentation/devicetree/bindings/usb/intel,keembay-
> dwc3.yaml
> index dd32c10ce6c7..43b91ab62004 100644
> --- a/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml
> @@ -34,11 +34,8 @@ properties:
>  # Required child node:
> 
>  patternProperties:
> -  "^dwc3@[0-9a-f]+$":
> -    type: object
> -    description:
> -      A child node must exist to represent the core DWC3 IP block.
> -      The content of the node is defined in dwc3.txt.
> +  "^usb@[0-9a-f]+$":
> +    $ref: snps,dwc3.yaml#
> 
>  required:
>    - compatible
> @@ -68,7 +65,7 @@ examples:
>            #address-cells = <1>;
>            #size-cells = <1>;
> 
> -          dwc3@...00000 {
> +          usb@...00000 {
>                  compatible = "snps,dwc3";
>                  reg = <0x34000000 0x10000>;
>                  interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
> --
> 2.29.2

Best regards,
Zainie

Powered by blists - more mailing lists