linux-kernel - Re: [PATCH v3 6/7] input: atc260x: Add onkey driver for ATC260x PMICs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X8xMTwaUYx+s1BG7@google.com>
Date:   Sat, 5 Dec 2020 19:13:19 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Cristian Ciocaltea <cristian.ciocaltea@...il.com>
Cc:     Lee Jones <lee.jones@...aro.org>, Rob Herring <robh+dt@...nel.org>,
        Sebastian Reichel <sre@...nel.org>,
        Mark Brown <broonie@...nel.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Andreas Färber <afaerber@...e.de>,
        linux-actions@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH v3 6/7] input: atc260x: Add onkey driver for ATC260x PMICs

On Sun, Dec 06, 2020 at 03:27:06AM +0200, Cristian Ciocaltea wrote:
> The Actions Semi ATC260x PMICs are able to manage an onkey button.
> This driver exposes the ATC260x onkey as an input device. It can also
> be configured to force a system reset on a long key-press with an
> adjustable duration.
> 
> The currently supported chip variants are ATC2603C and ATC2609A.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...il.com>
> ---
> Changes in v3: 
>  - Integrated Dmitry's review:
>    * Dropped the logic around the check for 'pdev->dev.of_node'
>    * Renamed 'ret' variable in 'atc260x_onkey_probe()' to 'error'
>    * Used 'dev_dbg' instead of 'dev_info' on status KEY_RESET_DISABLED
>    * Dropped 'input_dev->evbit[0] = BIT_MASK(EV_KEY);'
>    * Removed IRQF_TRIGGER_HIGH flag on 'devm_request_threaded_irq()'
>    * Implemented open/close to mitigate the racing issue in
>      'atc260x_onkey_remove()' which has been dropped now
>  - Removed the unnecessary driver compatibles
>  - Used 'reset-time-sec' property of the parent device instead of
>    'actions,reset-time-sec' of now obsolete and removed 'onkey' DT node

Acked-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Please merge with the rest through MFD I suppose.

Thanks.

-- 
Dmitry